Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "Right arrow autocompletes at line end" implementation #57273

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

KristofferC
Copy link
Member

Fixes #56864. The feature in #54983 never worked I think?

Ref

edit_splice!(s, (prev_pos - sizeof(partial)) => prev_pos, completions[1].completion)

@KristofferC KristofferC added REPL Julia's REPL (Read Eval Print Loop) bugfix This change fixes an existing bug backport 1.12 Change should be backported to release-1.12 labels Feb 5, 2025
@IanButterworth
Copy link
Member

IanButterworth commented Feb 5, 2025

I noticed another one here which hasn't changed in 7 years, which makes me think a method was deleted?

edit_splice!(s, (prev_pos - sizeof(partial)) => prev_pos, completions[1])

@IanButterworth
Copy link
Member

I tried to hit that 2nd one but couldn't figure out how.
I tried

julia> ctrl-R
(reverse-i-search)`':

Then typed ver and then tab or right arrow to complete to versioninfo() but tab did nothing and right arrow just exited search mode and moved the cursor one over.

@KristofferC KristofferC mentioned this pull request Feb 6, 2025
32 tasks
@KristofferC KristofferC merged commit f0446c6 into master Feb 6, 2025
4 of 7 checks passed
@KristofferC KristofferC deleted the kc/fix_repl_right branch February 6, 2025 12:03
KristofferC added a commit that referenced this pull request Feb 6, 2025
KristofferC added a commit that referenced this pull request Feb 13, 2025
Backported PRs:
- [x] #57142 <!-- Add reference to time_ns in time -->
- [x] #57241 <!-- Handle `waitpid` race condition when `SIGCHLD` is set
to `SIG_IGN` -->
- [x] #57249 <!-- restore non-freebsd-unix fix for profiling -->
- [x] #57211 <!-- Ensure read/readavailable for BufferStream are
threadsafe -->
- [x] #57262 <!-- edit NEWS for v1.12 -->
- [x] #57226 <!-- cfunction: reimplement, as originally planned, for
reliable performance -->
- [x] #57253 <!-- bpart: Fully switch to partitioned semantics -->
- [x] #57273 <!-- fix "Right arrow autocompletes at line end"
implementation -->
- [x] #57280 <!-- dep: Update JuliaSyntax -->
- [x] #57229 <!-- staticdata: Close data race after backedge insertion
-->
- [x] #57298 <!-- Updating binding version to fix MMTk CI -->
- [x] #57248 <!-- improve concurrency safety for `Compiler.finish!` -->
- [x] #57312 <!-- Profile.print: de-focus sleeping frames as gray -->
- [x] #57289 <!-- Make `OncePerX` subtype `Function` -->
- [x] #57310 <!-- Make ptls allocations at least 128 byte aligned -->
- [x] #57311 <!-- Add a warning for auto-import of types -->
- [x] #57338 <!-- fix typo in Float32 random number generation -->
- [x] #57293 <!-- Fix getfield_tfunc when order or boundscheck is Vararg
-->
- [x] #57349 <!-- docs: fix-up world-age handling for META access -->
- [x] #57344 <!-- Add missing type asserts when taking the queue out of
the task struct -->
- [x] #57348 <!-- 🤖 [master] Bump the SparseArrays stdlib from 212981b
to 72c7cac -->
- [x] #55040 <!-- Allow macrocall as function sig -->
- [x] #57299 <!-- Add missing latestworld after parameterized type alias
-->
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no method matching edit_splice!(...) when using the REPL
2 participants