Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip Module filename from metadata #57499

Merged
merged 1 commit into from
Feb 22, 2025
Merged

strip Module filename from metadata #57499

merged 1 commit into from
Feb 22, 2025
+6 −2

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 21, 2025

Fix #57358

@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Feb 22, 2025
@KristofferC KristofferC merged commit 88aa27f into master Feb 22, 2025
8 checks passed
@KristofferC KristofferC deleted the jn/57358 branch February 22, 2025 10:59
@oscardssmith
Copy link
Member

Can we get a test added to this?

@KristofferC
Copy link
Member

There are no tests for whether this feature (--strip-metadata) does anything at all so there is no simple incremental test that can be added like that. Doing a strings test on the output artifact of the juliac test is one way to start testing the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.12 Change should be backported to release-1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--strip-metadata does not strip module file metadata
3 participants
@vtjnash @oscardssmith @KristofferC