Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with A Triangular A_mul_B! overwrites B but Ac_mul_B! doesn't #7050

Closed
dmbates opened this issue May 30, 2014 · 2 comments
Closed

with A Triangular A_mul_B! overwrites B but Ac_mul_B! doesn't #7050

dmbates opened this issue May 30, 2014 · 2 comments
Assignees
Labels
domain:linear algebra Linear algebra kind:bug Indicates an unexpected problem or unintended behavior

Comments

@dmbates
Copy link
Member

dmbates commented May 30, 2014

(I meant to write "but Ac_mul_B! doesn't".)

julia> B = fill(5.,(1,4))
1x4 Array{Float64,2}:
 5.0  5.0  5.0  5.0

julia> A = Triangular(fill(0.723,(1,1)),:L,false)
1x1 Triangular{Float64}:
 0.723

julia> A_mul_B!(A,B)
1x4 Array{Float64,2}:
 3.615  3.615  3.615  3.615

julia> B
1x4 Array{Float64,2}:
 3.615  3.615  3.615  3.615

julia> B = fill(5.,(1,4))
1x4 Array{Float64,2}:
 5.0  5.0  5.0  5.0

julia> Ac_mul_B!(A,B)
1x4 Array{Float64,2}:
 3.615  3.615  3.615  3.615

julia> B
1x4 Array{Float64,2}:
 5.0  5.0  5.0  5.0

julia> versioninfo()
Julia Version 0.3.0-prerelease+3341
Commit c34e492* (2014-05-30 14:23 UTC)
Platform Info:
  System: Linux (x86_64-pc-linux-gnu)
  CPU: AMD Athlon(tm) II X4 635 Processor
  WORD_SIZE: 64
  BLAS: libopenblas (NO_LAPACK NO_LAPACKE DYNAMIC_ARCH NO_AFFINITY)
  LAPACK: liblapack
  LIBM: libopenlibm
@dmbates
Copy link
Member Author

dmbates commented May 30, 2014

It seems that the problem is that the A_mul_B! method calls BLAS.trmm! but Ac_mul_B! calls BLAS.trmm (w/o the '!').

@andreasnoackjensen Is this intentional?

@JeffBezanson JeffBezanson changed the title with A Triangular A_mul_B! overwrites B by Ac_mul_B! doesn't with A Triangular A_mul_B! overwrites B but Ac_mul_B! doesn't May 30, 2014
@andreasnoack andreasnoack self-assigned this Jun 1, 2014
@andreasnoack
Copy link
Member

Fixed by 547facf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra kind:bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants