Add inline macro via :meta expressions #8297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reinstates @vtjnash's contribution of the ability to declare that a function should be inlined. However, this implementation does it with an
@inline
macro and a newExpr(:meta, <metadata>...)
construct. meta-expressions can be used for other things too (I wonder if @ArchRobison may be interested in using it to introduce@SLPvectorize
...)Demo:
Everything seems to work,
except for some reason my attempt to "register" the(EDIT: see below):meta_sym
doesn't seem to have succeededAnyone know why? @ArchRobison, you had to go through this with
simdloop_sym
, any tips?Reference: discussion starting at #3796 (comment).
Also CC @carlobaldassi (cartesian iteration).