Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for l/rpad with > 1 length padding string #11924

Merged
merged 1 commit into from Jun 29, 2015
Merged

Fix for l/rpad with > 1 length padding string #11924

merged 1 commit into from Jun 29, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2015

On master:

julia> lpad("foo", 5, "  ")
ERROR: BoundsError: attempt to access "  "
  at index [0]
 in checkbounds at ./string.jl:148
 in lpad at ./string.jl:1305

And:

julia> rpad("foo", 5, "  ")
ERROR: BoundsError: attempt to access "  "
  at index [0]
 in checkbounds at ./string.jl:148
 in rpad at string.jl:1317

@ghost
Copy link
Author

ghost commented Jun 29, 2015

Yet another timeout on AppVeyor, it looks good to merge to me.

@tkelman tkelman added the bug Indicates an unexpected problem or unintended behavior label Jun 29, 2015
@tkelman
Copy link
Contributor

tkelman commented Jun 29, 2015

lgtm, appveyor failure is #11818

tkelman added a commit that referenced this pull request Jun 29, 2015
@tkelman
Merge pull request #11924 from ninjin/nin/pad
89fbb19 
Fix for l/rpad with > 1 length padding string
@tkelman tkelman merged commit 89fbb19 into JuliaLang:master Jun 29, 2015
@ScottPJones ScottPJones mentioned this pull request Jul 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkelman