Apply suggestions from code review

Co-authored-by: Jameson Nash <vtjnash@gmail.com>

Author: staticfloat

configure.ac

@@ -74,7 +74,7 @@ AM_CONDITIONAL([OS400],    [AS_CASE([$host_os],[os400],         [true], [false])
 AM_CONDITIONAL([SUNOS],    [AS_CASE([$host_os],[solaris*],      [true], [false])])
 AM_CONDITIONAL([WINNT],    [AS_CASE([$host_os],[mingw*],        [true], [false])])
 AS_CASE([$host_os],[mingw*], [
-    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32 -lwer -ldbghelp"
+    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32 -ldbghelp -lole32 -luuid"
 ])
 AS_CASE([$host_os], [netbsd*], [AC_CHECK_LIB([kvm], [kvm_open])])
 AS_CASE([$host_os], [kfreebsd*], [

src/win/process.c

@@ -1252,20 +1252,22 @@ static int uv__kill(HANDLE process_handle, int signum) {
     return UV_EINVAL;
   }
 
-  // Create a dump file for the targeted process, if the registry key
-  // `HKLM:Software\Microsoft\Windows\Windows Error Reporting\LocalDumps\DumpFolder`
-  // points to a valid folder.  The default value if the registry key does not
-  // exist is `%LOCALAPPDATA%\CrashDumps`, see [0] for more detail.
-  // [0]: https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
+  /*
+   * Create a dump file for the targeted process, if the registry key
+   * `HKLM:Software\Microsoft\Windows\Windows Error Reporting\LocalDumps\DumpFolder`
+   * points to a valid folder.  The default value if the registry key does not
+   * exist is `%LOCALAPPDATA%\CrashDumps`, see [0] for more detail.
+   * [0]: https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
+   */
   if (signum == SIGQUIT) {
-    // Get process name
+    /* Get target process name. */
     WCHAR basename[MAX_PATH];
     GetModuleBaseNameW(process_handle, NULL, &basename[0], sizeof(basename));
 
-    // Get PID
+    /* Get PID of target process. */
     DWORD pid = GetProcessId(process_handle);
 
-    // Get LocalDumps directory path:
+    /* Get LocalDumps directory path. */
     HKEY registry_key;
     WCHAR dump_folder[MAX_PATH];
     DWORD ret = RegOpenKeyExW(HKEY_LOCAL_MACHINE,
@@ -1284,22 +1286,21 @@ static int uv__kill(HANDLE process_handle, int signum) {
                           (PVOID) dump_folder,
                           &dump_folder_len);
       if (ret != ERROR_SUCCESS) {
-        // Default value for `dump_folder` is `%LOCALAPPDATA%\CrashDumps`
+        /* Default value for `dump_folder` is `%LOCALAPPDATA%\CrashDumps`. */
         WCHAR * localappdata;
         SHGetKnownFolderPath(&FOLDERID_LocalAppData, 0, NULL, &localappdata);
-        swprintf_s(dump_folder, sizeof(dump_folder), L"%ls\\CrashDumps", localappdata);
+        _snwprintf(dump_folder, sizeof(dump_folder), L"%ls\\CrashDumps", localappdata);
         CoTaskMemFree(localappdata);
       }
       RegCloseKey(registry_key);
-    }
 
-    // Construct dump filename
+    /* Construct dump filename. */
     WCHAR dump_name[MAX_PATH];
     swprintf_s(dump_name, sizeof(dump_name), L"%ls\\%ls.%d.dmp", dump_folder, basename, pid);
 
     HANDLE hDumpFile = CreateFileW(dump_name, GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL);
     if (hDumpFile != INVALID_HANDLE_VALUE) {
-      // Tell wine to dump ELF modules as well
+      /* Tell wine to dump ELF modules as well */
       DWORD sym_options = SymGetOptions();
       SymSetOptions(sym_options | 0x40000000);
       MiniDumpWriteDump(