[Windows] Write out minidumps on reception of SIGQUIT

This commit adds the ability to dump core when sending the `SIGQUIT`
signal on Windows.  The change reads in the current registry setting for
local dumps, and attempts to write out to that location before killing
the process.  See [0] for registry and pathing details. This behavior
mimics that of the dumps created by the typical Windows
Error Reporting mechanism.

[0] https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps

Author: staticfloat

configure

@@ -15138,7 +15138,7 @@ fi
 
 case $host_os in
   mingw*)
-    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32"
+    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32 -ldbghelp -lole32 -luuid"
  ;;
 esac
 case $host_os in

configure.ac

@@ -74,7 +74,7 @@ AM_CONDITIONAL([OS400],    [AS_CASE([$host_os],[os400],         [true], [false])
 AM_CONDITIONAL([SUNOS],    [AS_CASE([$host_os],[solaris*],      [true], [false])])
 AM_CONDITIONAL([WINNT],    [AS_CASE([$host_os],[mingw*],        [true], [false])])
 AS_CASE([$host_os],[mingw*], [
-    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32"
+    LIBS="$LIBS -lws2_32 -lpsapi -liphlpapi -lshell32 -lsecur32 -luserenv -luser32 -ldbghelp -lole32 -luuid"
 ])
 AS_CASE([$host_os], [netbsd*], [AC_CHECK_LIB([kvm], [kvm_open])])
 AS_CASE([$host_os], [kfreebsd*], [

include/uv/win.h

@@ -57,6 +57,7 @@ typedef intptr_t ssize_t;
 /* Signals supported by uv_signal and or uv_kill */
 #define SIGHUP                1
 #define SIGINT                2
+#define SIGQUIT               3
 #define SIGILL                4
 #define SIGABRT_COMPAT        6
 #define SIGFPE                8

src/win/process.c

@@ -30,6 +30,9 @@
 #include "internal.h"
 #include "handle-inl.h"
 #include "req-inl.h"
+#include <dbghelp.h>
+#include <shlobj.h>
+#include <psapi.h>     /* GetModuleBaseNameW */
 
 
 typedef struct env_var {
@@ -1250,7 +1253,82 @@ static int uv__kill(HANDLE process_handle, int signum) {
     return UV_EINVAL;
   }
 
+  /*
+   * Create a dump file for the targeted process, if the registry key
+   * `HKLM:Software\Microsoft\Windows\Windows Error Reporting\LocalDumps\DumpFolder`
+   * points to a valid folder.  The default value if the registry key does not
+   * exist is `%LOCALAPPDATA%\CrashDumps`, see [0] for more detail.
+   * [0]: https://learn.microsoft.com/en-us/windows/win32/wer/collecting-user-mode-dumps
+   */
+  if (signum == SIGQUIT) {
+    /* Get target process name. */
+    WCHAR basename[MAX_PATH];
+    GetModuleBaseNameW(process_handle, NULL, &basename[0], sizeof(basename));
+
+    /* Get PID of target process. */
+    DWORD pid = GetProcessId(process_handle);
+
+    /* Get LocalDumps directory path. */
+    HKEY registry_key;
+    WCHAR dump_folder[MAX_PATH];
+    DWORD ret = RegOpenKeyExW(HKEY_LOCAL_MACHINE,
+                  L"SOFTWARE\\Microsoft\\Windows\\Windows Error Reporting\\LocalDumps",
+                  0,
+                  KEY_QUERY_VALUE,
+                  &registry_key);
+    if (ret == ERROR_SUCCESS) {
+      DWORD dump_folder_len = sizeof(dump_folder);
+      DWORD key_type = 0;
+      ret = RegGetValueW(registry_key,
+                          NULL,
+                          L"DumpFolder",
+                          RRF_RT_ANY,
+                          &key_type,
+                          (PVOID) dump_folder,
+                          &dump_folder_len);
+      if (ret != ERROR_SUCCESS) {
+        /* Default value for `dump_folder` is `%LOCALAPPDATA%\CrashDumps`. */
+        WCHAR * localappdata;
+        SHGetKnownFolderPath(&FOLDERID_LocalAppData, 0, NULL, &localappdata);
+        _snwprintf_s(dump_folder, sizeof(dump_folder), _TRUNCATE, L"%ls\\CrashDumps", localappdata);
+        CoTaskMemFree(localappdata);
+      }
+      RegCloseKey(registry_key);
+    }
+
+    /* Construct dump filename. */
+    WCHAR dump_name[MAX_PATH];
+    _snwprintf_s(dump_name, sizeof(dump_name), _TRUNCATE, L"%ls\\%ls.%d.dmp", dump_folder, basename, pid);
+
+    HANDLE hDumpFile = CreateFileW(dump_name, GENERIC_WRITE, 0, NULL, CREATE_NEW, FILE_ATTRIBUTE_NORMAL, NULL);
+    if (hDumpFile != INVALID_HANDLE_VALUE) {
+      /* If something goes wrong while writing it out, delete the file to prevent clutter accumulation. */
+      FILE_DISPOSITION_INFO DeleteOnClose = { TRUE };
+      SetFileInformationByHandle(hDumpFile, FileDispositionInfo, &DeleteOnClose, sizeof(DeleteOnClose));
+
+      /* Tell wine to dump ELF modules as well. */
+      DWORD sym_options = SymGetOptions();
+      SymSetOptions(sym_options | 0x40000000);
+
+      if (MiniDumpWriteDump(process_handle, pid, hDumpFile,
+                            /*
+                             * We default to a rather large dump, so as to be more useful for debugging.
+                             * In the future, we may want to allow customization of what kinds of dumps
+                             * to create, as not all clients may wish to create such a large dump.
+                             */
+                            MiniDumpWithFullMemory | MiniDumpIgnoreInaccessibleMemory | MiniDumpWithAvxXStateContext,
+                            NULL, NULL, NULL) == TRUE) {
+        /* Don't delete the file on close if we successfully wrote it out. */
+        FILE_DISPOSITION_INFO DeleteOnClose = { FALSE };
+        SetFileInformationByHandle(hDumpFile, FileDispositionInfo, &DeleteOnClose, sizeof(DeleteOnClose));
+      }
+      SymSetOptions(sym_options);
+      CloseHandle(hDumpFile);
+    }
+  }
+
   switch (signum) {
+    case SIGQUIT:
     case SIGTERM:
     case SIGKILL:
     case SIGINT: {