You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One hurdle is that open on an S3Path returns an FilePathsBase.FileBuffer <: IO object but not an IOStream. So those types would need to be widened too. We could widen to IO if type stability is not a big problem here, or else add a depedency on FilePathsBase and type them as Union{IOStream, FileBuffer}.
Also, there isn't really a common supertype of String and S3Path, but could do Union{String, AbstractPath} if we added a dep on FilePathsBase. Or just Any if type stability here isn't a bottleneck. I'm guessing often the 20 microseconds of dynamic dispatch is less than the cost of IO but I don't really know how TensorBoardLogger works.
Since tensorboard supports logdirs being in s3 directly, it would be nice to be able to write to s3 directly too!
The text was updated successfully, but these errors were encountered: