Skip to content

Feature request: Support AWSS3.S3Paths #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ericphanson opened this issue Jul 16, 2021 · 2 comments · Fixed by #103
Closed

Feature request: Support AWSS3.S3Paths #102

ericphanson opened this issue Jul 16, 2021 · 2 comments · Fixed by #103

Comments

@ericphanson
Copy link
Member

Since tensorboard supports logdirs being in s3 directly, it would be nice to be able to write to s3 directly too!

@ericphanson ericphanson changed the title Feature request: Support AWSS3.S3Paths Feature request: Support AWSS3.S3Paths Jul 16, 2021
@PhilipVinc
Copy link
Member

I don’t have time to work on this and soon will leave for holidays.
However if you open a PR I’ll gladly review it quickly.

this should be as easy as changing the type restriction on the path from a string to a more general path

@ericphanson
Copy link
Member Author

One hurdle is that open on an S3Path returns an FilePathsBase.FileBuffer <: IO object but not an IOStream. So those types would need to be widened too. We could widen to IO if type stability is not a big problem here, or else add a depedency on FilePathsBase and type them as Union{IOStream, FileBuffer}.

Also, there isn't really a common supertype of String and S3Path, but could do Union{String, AbstractPath} if we added a dep on FilePathsBase. Or just Any if type stability here isn't a bottleneck. I'm guessing often the 20 microseconds of dynamic dispatch is less than the cost of IO but I don't really know how TensorBoardLogger works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants