Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Requires.jl to make LightGraphs a soft dependency? #39

Closed
oxinabox opened this issue Jul 9, 2019 · 2 comments
Closed

Use Requires.jl to make LightGraphs a soft dependency? #39

oxinabox opened this issue Jul 9, 2019 · 2 comments

Comments

@oxinabox
Copy link
Member

oxinabox commented Jul 9, 2019

It would mean that logging graphs would only be enabled in you had LightGraphs loaded.

But then we can cut down our dependencies significantly.

@PhilipVinc
Copy link
Member

PhilipVinc commented Jul 12, 2019

I'm personally in favor of anything that cuts down on the dependencies of this package.
But, didn't you have reservations against using Requires.jl ? Or those issues have been fixed?

@oxinabox
Copy link
Member Author

oxinabox commented Jul 12, 2019

I do have reservations about Requires.jl,
it causes a big increase in load time when you load the package that is hidden behind it gets loaded.

but I think that is worth it to drop the dependency.

It also voids your ability to check versions of the Required package, but that is not so bad since we only use fairly basic functions that are unlikely to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants