Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy operations should be opt-in #74

Open
CarloLucibello opened this issue Apr 11, 2022 · 1 comment
Open

Lazy operations should be opt-in #74

CarloLucibello opened this issue Apr 11, 2022 · 1 comment
Labels

Comments

@CarloLucibello
Copy link
Member

Operation like splitobs, shuffleobs and many more return ObsViews that one has to call getobs on in order to materialize.
I think this is unexpected for users coming from scikit-learn and mildly annoying in most scenarios.
As a default, operations on materialized objects should return materialized objects (e.g. arrays and dataframes).
Users will be able to opt-in on the "lazy" by wrapping data in a ObsView. Operations on ObsView will produce other ObsView that can be materialized only at the end of the pipeline.

@darsnack
Copy link
Member

Makes a lot of sense to me. Maybe we should rename ObsView to LazyView to indicate that it is both a view (subset) of the observations as well as being lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants