Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the Manifolds extension maybe not work? #20

Closed
kellertuer opened this issue Jun 3, 2023 · 5 comments · Fixed by #21
Closed

Does the Manifolds extension maybe not work? #20

kellertuer opened this issue Jun 3, 2023 · 5 comments · Fixed by #21

Comments

@kellertuer
Copy link
Member

kellertuer commented Jun 3, 2023

Yesterda< I removed the cache from the Quarto tutorials CI over on Manifolds.jl and merged said PR today. Today the rendering (even in the notebook) there an error

https://juliamanifolds.github.io/Manifolds.jl/latest/tutorials/getstarted.html

I am not sure why that is even happening over there since the tutorial environment and the tutorial do not use ManifoldDiff I think, but the error sounds like it is coming from here?

edit: I get the same error, then I start an empty environment and install Manifolds.jl

@mateuszbaran
Copy link
Member

Hm, we probably should move the manifolds extension to Manifolds.jl.

@kellertuer
Copy link
Member Author

I have not yet understood what the actual error here is and why ProductManifold is not found.

I am not sure for this one, where it fits better. Maybe in Manifolds is better if we consider that the central place.

@mateuszbaran
Copy link
Member

The error makes little sense to me. Manifolds.jl depends on ManifoldDiff.jl though so moving these parts to Manifolds.jl seems reasonable and would solve this issue.

@kellertuer
Copy link
Member Author

sounds good, then lets move that ext.

@mateuszbaran
Copy link
Member

I will do that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants