Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU support #228

Open
mateuszbaran opened this issue Oct 2, 2020 · 5 comments
Open

GPU support #228

mateuszbaran opened this issue Oct 2, 2020 · 5 comments

Comments

@mateuszbaran
Copy link
Member

I checked how hard would it be to add GPU support to Manifolds.jl. Essentially without some kind of contextual dispatch (like this: JuliaGPU/CUDAnative.jl#334 ) it would require rewriting almost everything.

@kellertuer
Copy link
Member

I would have to first read about GPU support in general, but yes it would be great, especially for large power manifolds to have GPU support.

@mateuszbaran
Copy link
Member Author

I'm not even sure what would I recommend reading here, usually GPU support is done from the other side than I'd prefer to do it here: each manifold is implemented to also handle its own powers (e.g. Pymanopt, Geomstats). That puts on us the burden of handling power manifolds separately for each manifold, doesn't scale to product manifolds and is troublesome when someone cares about performance in low-dimensional cases.

Here I'd prefer to just rewrite PowerManifold to automatically generate GPU kernels from CPU implementations of methods. That's not always possible but with contextual dispatch we should be able to automatically offload to GPU most non-allocating operations (GPU code can't really allocate).

@kellertuer
Copy link
Member

Thanks for the explanation, I actually still prefer our generic approach to power manifolds and rewrite that one, too.

@mateuszbaran
Copy link
Member Author

@sethaxen
Copy link
Member

Yeah KernelAbstractions that was just recommended to me and seems like it might be promising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants