-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU support #228
Comments
I would have to first read about GPU support in general, but yes it would be great, especially for large power manifolds to have GPU support. |
I'm not even sure what would I recommend reading here, usually GPU support is done from the other side than I'd prefer to do it here: each manifold is implemented to also handle its own powers (e.g. Pymanopt, Geomstats). That puts on us the burden of handling power manifolds separately for each manifold, doesn't scale to product manifolds and is troublesome when someone cares about performance in low-dimensional cases. Here I'd prefer to just rewrite |
Thanks for the explanation, I actually still prefer our generic approach to power manifolds and rewrite that one, too. |
Related thing: https://github.com/JuliaGPU/KernelAbstractions.jl . |
Yeah KernelAbstractions that was just recommended to me and seems like it might be promising. |
I checked how hard would it be to add GPU support to Manifolds.jl. Essentially without some kind of contextual dispatch (like this: JuliaGPU/CUDAnative.jl#334 ) it would require rewriting almost everything.
The text was updated successfully, but these errors were encountered: