Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the rotations manifold also for quarternions #529

Open
kellertuer opened this issue Sep 8, 2022 · 4 comments
Open

Implement the rotations manifold also for quarternions #529

kellertuer opened this issue Sep 8, 2022 · 4 comments
Labels
extend manifold This issue proposes/asks for new functions to extend an existing manifold good first issue Good for newcomers

Comments

@kellertuer
Copy link
Member

For Rotations(3) we could also implement the main functions using quaternions., since this is used in a lot of applications.

@kellertuer kellertuer added good first issue Good for newcomers extend manifold This issue proposes/asks for new functions to extend an existing manifold labels Sep 8, 2022
@sethaxen
Copy link
Member

sethaxen commented Sep 8, 2022

Does this require depending on a specific quaternion implementation?

@kellertuer
Copy link
Member Author

...probably, I have not yet checked which ones we could use?

@sethaxen
Copy link
Member

sethaxen commented Sep 8, 2022

There's (at least) Quaternions.jl (the most used) and Quaternionic.jl. Quaternions is working to drop its only dependency (JuliaGeometry/Quaternions.jl#79 (comment)).

Then Rotations.jl has a 3x3 matrix whose underlying storage is a unit quaternion. This type could already be used with Manifolds.jl, but I think everything would end up being promoted to a 3x3 static array instead of working with the unit quaternions directly much.

@kellertuer
Copy link
Member Author

Then maybe lets wait for that dependency to drop and then look which formulae we could easily get for our functions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extend manifold This issue proposes/asks for new functions to extend an existing manifold good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants