Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for rounding modes for division for FixedDecimals #50

Closed
NHDaly opened this issue Oct 28, 2019 · 0 comments · Fixed by #51
Closed

Add support for rounding modes for division for FixedDecimals #50

NHDaly opened this issue Oct 28, 2019 · 0 comments · Fixed by #51
Labels
enhancement

Comments

@NHDaly
Copy link
Member

NHDaly commented Oct 28, 2019 •
edited
Loading

Julia 1.4 (JuliaLang/julia#33040) adds a standard interface to specify the rounding mode for integer division div(x, y, ::RoundingMode). FixedDecimals should implement this interface as well, to support different rounding modes for division.

We've wanted to support rounding divisions for a while, anyway, so this a nice motivator.

This was originally discussed in this issue:
JuliaLang/julia#33651
@NHDaly NHDaly changed the title TODO: Add support for rounding modes for division for FixedDecimals Add support for rounding modes for division for FixedDecimals Oct 28, 2019
@NHDaly NHDaly mentioned this issue Feb 1, 2020
Merged
@NHDaly NHDaly closed this as completed in #51 Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for three-arg div to FixedDecimals in Julia 1.4+ JuliaMath/FixedPointDecimals.jl
1 participant
@NHDaly