-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make DualNumbers a weak dependency #57
Comments
I don’t there’s a deep reason other than at one point I tried to auto-diff a hyper geometric function. I think just removing the code is fine |
Pro: it's reasonable to remove superfluous dependencies. (I'm always in favour of that!) As a historical note, this repository started as a submodule in SingularIntegralEquations.jl but was made into a package ostensibly to remove the Looking at #59, it seems that continuing support in SingularIntegralEquations.jl would require duplicating the methods that are no longer declared for |
DualNumbers has been a direct dependency of this package for about as long as this package has tracked its dependencies. Methods of some internal functions are defined for
Dual
but dual numbers don't seem to actually be used. As far as I can tell, it would be a non-functional change from this package's perspective to remove the dependency and the methods. That said, I don't know whether there was a reason (e.g. integration with some other specific downstream package) that these methods are defined forDual
. If it's important to have those methods defined, they could potentially be moved to an extension (for Julia 1.9+), or otherwise perhaps the dependency can be removed altogether.The text was updated successfully, but these errors were encountered: