Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why a subtype of AbstractArray? #345

Closed
stevengj opened this issue Dec 5, 2019 · 1 comment
Closed

why a subtype of AbstractArray? #345

stevengj opened this issue Dec 5, 2019 · 1 comment

Comments

@stevengj
Copy link
Member

stevengj commented Dec 5, 2019 •
edited
Loading

Currently, you have AbstractInterpolation <: AbstractArray (here).

This doesn't make sense to me, since it doesn't support getindex and generally doesn't act like an array.

(Though it would be nice to expose an iterator for the knots etc.)
@stevengj stevengj changed the title why a subtype of AbstractArray why a subtype of AbstractArray? Dec 5, 2019
@timholy
Copy link
Member

timholy commented Dec 5, 2019

This package used to have a getindex-based interface, but we've started transitioning away from it. It's mostly a question of someone sitting down and finishing this.

Duplicate of #242.

@stevengj stevengj closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timholy @stevengj