Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename length to width/duration #31

Closed
dlfivefifty opened this issue Jul 26, 2018 · 2 comments
Closed

Rename length to width/duration #31

dlfivefifty opened this issue Jul 26, 2018 · 2 comments

Comments

@dlfivefifty
Copy link
Member

length is used extensively in Base for iterator and broadcasting behaviour, and so overriding length(::ClosedInterval) to mean something other than the iterator length is a bad idea.

I'd propose calling it arclength.
@dlfivefifty
Copy link
Member Author

Hmm, I forgot that I already did this in the PR as width.

@dlfivefifty dlfivefifty mentioned this issue Jul 31, 2018
Merged
@dlfivefifty dlfivefifty changed the title Rename length to arclength Rename length to width Jul 31, 2018
@dlfivefifty dlfivefifty changed the title Rename length to width Rename length to width/duration Jul 31, 2018
@hyrodium
Copy link
Collaborator

The width was already added, and the method for length was removed in #92.

This was referenced Apr 13, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlfivefifty @hyrodium