Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should AbstractPolynomial subtype Function? #516

Closed
nsajko opened this issue Jul 30, 2023 · 2 comments
Closed

Should AbstractPolynomial subtype Function? #516

nsajko opened this issue Jul 30, 2023 · 2 comments

Comments

@nsajko
Copy link
Contributor

nsajko commented Jul 30, 2023

Since AbstractPolynomial types are required to be callable, wouldn't it make sense to change the definition from

abstract type AbstractPolynomial{T,X} end

to

abstract type AbstractPolynomial{T,X} <: Function end

Then polynomials would be accepted anywhere functions are.

@jverzani
Copy link
Member

Yeah, this has come up with plotting recipes as useful. I've always been wary, as I'm a bit biased towards the interpretation that polynomials are more like abstract vectors with an offset.

@nsajko
Copy link
Contributor Author

nsajko commented Jul 31, 2023

Makes sense.

@nsajko nsajko closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants