Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Regression when using Threads Backend #156

Closed
alexishuante opened this issue Nov 26, 2024 · 4 comments
Closed

Performance Regression when using Threads Backend #156

alexishuante opened this issue Nov 26, 2024 · 4 comments

Comments

@alexishuante
Copy link

Hello,

It seems that currently there is an issue with JACC v0.1.0 where the performance when using the Threads Backend is worse compared to JACC v0.0.5.

When running a kernel, I got an average iteration time of 5.77 seconds when using JACC v0.0.5. Whereas for JACC v0.1.0, I got an average iteration time of 546 seconds.

When I ran a profiler, it seemed pointing to a possible task management overhead, meaning the threading backend is spending a lot of time scheduling and managing tasks.

Let me know if there is anything I can do to help.

Thank you.

@williamfgc
Copy link
Collaborator

Hi @alexishuante , please provide the kernel code for reproducibility. Thanks!

@alexishuante
Copy link
Author

Here is the kernel code I used: https://github.com/jhonnygzz/JACC_APPS/tree/main/miniBUDEJACC
To reproduce these results, the instructions are provided in the README.md. I also used export JULIA_EXCLUSIVE=1 and export JULIA_NUM_THREADS=128.

Thank you.

@williamfgc
Copy link
Collaborator

@alexishuante please feel free to test with the latest main branch and close this issue if fixed. Thanks!

@alexishuante
Copy link
Author

I can confirm that JACC v0.1.1 fixes the regression problem in threads. I made a mistake in my run test case. I will close this issue since the problem is now fixed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants