Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOS expanded cxx string ABIs are identical #316

Closed
visr opened this issue Dec 21, 2019 · 4 comments · Fixed by #392 or JuliaGeo/LibGEOS.jl#68
Closed

GEOS expanded cxx string ABIs are identical #316

visr opened this issue Dec 21, 2019 · 4 comments · Fixed by #392 or JuliaGeo/LibGEOS.jl#68

Comments

@visr
Copy link
Contributor

visr commented Dec 21, 2019

This already came up in #293 (comment), but making a separate issue to keep GEOS issues out of the GDAL PR discussion.

In #302 we expanded the cxx string ABIs for GEOS. However the files for both builds are identical apart from the log. Both are built with cxx11 string ABI.

Does anyone have an idea why expand_cxxstring_abis is not working here, and how we can make it work?

https://github.com/JuliaBinaryWrappers/GEOS_jll.jl/releases/tag/GEOS-v3.8.0%2B2
https://github.com/libgeos/geos

@giordano
Copy link
Member

What I find interesting is that building locally twice for the same platform and the same string ABI I get non-identical files. I think it's very surprising that there are identical libraries in two different builds (moreover targeting different string ABIs)

@visr
Copy link
Contributor Author

visr commented Dec 29, 2019

I just tried running these two on BinaryBuilder master:

julia --color=yes build_tarballs.jl --verbose --debug x86_64-linux-gnu-cxx03,x86_64-linux-gnu-cxx11

And still got tarballs that are identical apart from the log.

From doing a

nm -gCD libgeos.so | grep basic_string

on the cxx03 build and getting only std::__cxx11::basic_string back, I gather that the expand_cxxstring_abis hasn't worked.

Is there anything else I can do to make it use the cxx03 string ABI?

@visr visr mentioned this issue Jan 9, 2020
@visr
Copy link
Contributor Author

visr commented Jan 15, 2020

@staticfloat do you maybe have any insights here? Would love to get unstuck for the GEOS -> GDAL builds.

@staticfloat
Copy link
Member

staticfloat commented Jan 15, 2020

However the files for both builds are identical apart from the log. Both are built with cxx11 string ABI.

That's not good! That means there's probably a BB bug. Can you point me to the resultant files? EDIT: Nevermind, I saw the link in your top post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants