Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch GCC 11 build to fix AMX instructions #8001

Closed
imciner2 opened this issue Jan 23, 2024 · 0 comments · Fixed by #8005
Closed

Patch GCC 11 build to fix AMX instructions #8001

imciner2 opened this issue Jan 23, 2024 · 0 comments · Fixed by #8005
Assignees

Comments

@imciner2
Copy link
Member

To build the OpenBLAS BFloat16 extensions on Windows, we need to patch the GCC AMX intrinsics header to fix two sets of typos:

These two patches are both in GCC 12.3 and GCC 13, but we can't switch to using that for OpenBLAS yet, so we need to live with GCC 11.

The first one is probably harmless, but was still a typo none the less. The second I believe is actively breaking the OpenBLAS build with BFloat16 enabled for the Windows 64-bit platform in #7202 with the errors

[18:55:08] /tmp/ccNhJljp.s: Assembler messages:
[18:55:08] /tmp/ccNhJljp.s:108: Error: `(%rax,%r10d,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:111: Error: `(%rdx,%r11d,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:125: Error: `(%r8,%r10d,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:131: Error: `(%rcx,%eax,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:175: Error: `(%r8,%ebx,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:178: Error: `(%rax,%r11d,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:195: Error: `(%rdx,%eax,1)' is not a valid base/index expression
[18:55:08] /tmp/ccNhJljp.s:203: Error: `(%rcx,%eax,1)' is not a valid base/index expression
[18:55:08] make[1]: *** [Makefile.L3:637: sbgemm_oncopy_SAPPHIRERAPIDS.obj] Error 1

More details in OpenMathLib/OpenBLAS#4450 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant