Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fails on master because of change to Exception internals #211

Closed
andreasnoack opened this issue Aug 28, 2019 · 0 comments · Fixed by #212
Closed

Tests fails on master because of change to Exception internals #211

andreasnoack opened this issue Aug 28, 2019 · 0 comments · Fixed by #212
Assignees

Comments

@andreasnoack
Copy link
Member

try
sum(DA, dims=-1)
catch err
if isa(err, CompositeException)
@test !isempty(err.exceptions)
for excep in err.exceptions
# Unpack the remote exception
orig_err = excep.ex.captured.ex
@test isa(orig_err, ArgumentError)
end
else
@test isa(err, ArgumentError)
end
end
try
sum(DA, dims=0)
catch err
if isa(err, CompositeException)
@test !isempty(err.exceptions)
for excep in err.exceptions
# Unpack the remote exception
orig_err = excep.ex.captured.ex
@test isa(orig_err, ArgumentError)
end
else
@test isa(err, ArgumentError)
end
end

hooks into internals of the exceptions which seems to have changed in Julia 1.3 causing an error, see https://gist.github.com/KristofferC/bd078abfa9434082d9100e799280107d#file-distributedarrays-log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants