Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CUDA compat #774

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Bump CUDA compat #774

merged 3 commits into from
Sep 28, 2023

Conversation

simonbyrne
Copy link
Member

No description provided.

@luraess
Copy link
Contributor

luraess commented Sep 26, 2023

I guess one could also bump it in test

CUDA = "3, 4"

@simonbyrne
Copy link
Member Author

Good catch!

@lcw
Copy link
Member

lcw commented Sep 28, 2023

Is this ready to merge and a new release made?

@simonbyrne
Copy link
Member Author

We should probably make sure the CUDA tests pass...

@lcw
Copy link
Member

lcw commented Sep 28, 2023

We should probably make sure the CUDA tests pass...

Probably a good idea :-). It looks like there are some scalar indexing issues at least.

@luraess
Copy link
Contributor

luraess commented Sep 28, 2023

Yeah - seems indeed first failure occurs because of scalar indexing (was already the case with CUDA 4). For ROCm, it could be that the issue is related to an not fully working ROCm-aware MPI install on the CI machine

@simonbyrne simonbyrne merged commit 634a524 into master Sep 28, 2023
39 of 44 checks passed
@simonbyrne simonbyrne deleted the sb/cuda-compat branch September 28, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants