Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip threads tests which are known to fail #791

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Skip threads tests which are known to fail #791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef360f
Skip threads tests with legacy Intel MPI which are known to fail
giordano Nov 3, 2023
43b325f
Skip threads tests also on 32-bit Windows
giordano Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,21 @@ istest(f) = endswith(f, ".jl") && startswith(f, "test_") && !in(f, excludefiles)
testfiles = sort(filter(istest, readdir(testdir)))

@testset "$f" for f in testfiles
mpiexec() do mpirun
cmd(n=nprocs) = `$mpirun -n $n $(Base.julia_cmd()) --startup-file=no $(joinpath(testdir, f))`
cmd(n=nprocs) = `$(mpiexec()) -n $n $(Base.julia_cmd()) --startup-file=no $(joinpath(testdir, f))`
if f == "test_spawn.jl"
# Some command as the others, but always use a single process
run(cmd(1))
elseif f == "test_threads.jl"
# Legacy Intel MPI (before 2020) crashes threads tests:
# <https://github.com/JuliaParallel/MPI.jl/issues/725>. These tests fail also on
# 32-bit Windows: <https://github.com/JuliaParallel/MPI.jl/issues/711>.
if (MPI.MPI_LIBRARY == "IntelMPI" && MPI.MPI_LIBRARY_VERSION < v"2020") || (Sys.iswindows() && Sys.WORD_SIZE == 32)
@test_broken false
else
withenv("JULIA_NUM_THREADS" => "4") do
run(cmd())
end
end
elseif f == "test_error.jl"
r = run(ignorestatus(cmd()))
@test !success(r)
Expand All @@ -108,4 +114,3 @@ testfiles = sort(filter(istest, readdir(testdir)))
end
@test true
end
end
Loading