You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@warn"Attribute alias `$k` detected in the $recipe_type recipe defined for the signature $signature_string. To ensure expected behavior it is recommended to use the default attribute `$dk`."
If instead the string is computed only if the warning is determined to appear, this slowdown should go away. This would probably also lead to a small speedup on 1.5 and earlier since the userrecipe_signature_string also shows up on the 1.5 profile in the issue above.
Ref: JuliaLang/julia#39509
The new short-form type computation in 1.6 slows down the computation of the user recipe signature here:
https://github.com/JuliaPlots/RecipesPipeline.jl/blob/c251015a5420818229cdfd284c0802a7db19085c/src/utils.jl#L232-L234
As a fix, it looks as if this string computation is only made to potentially display a warning in
warn_on_recipe_aliases!
:Plots.jl/src/pipeline.jl
Lines 5 to 20 in a955ded
If instead the string is computed only if the warning is determined to appear, this slowdown should go away. This would probably also lead to a small speedup on 1.5 and earlier since the
userrecipe_signature_string
also shows up on the 1.5 profile in the issue above.As far as I can tell, this would require changing 4 calls to
warn_on_recipe_aliases!
in RecipesPipeline by passing the argument directly, instead of stringifying first:https://github.com/JuliaPlots/RecipesPipeline.jl/search?q=warn_on_recipe_aliases%21
The text was updated successfully, but these errors were encountered: