Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] marker_z should enforce same length as number of markers #4077

Open
BioTurboNick opened this issue Jan 26, 2022 · 2 comments
Open

[FR] marker_z should enforce same length as number of markers #4077

BioTurboNick opened this issue Jan 26, 2022 · 2 comments

Comments

@BioTurboNick
Copy link
Member

BioTurboNick commented Jan 26, 2022

I missed a pretty bad mistake in my code for a while because marker_z is permissive for too-long input. It throws an error if the input is too short.

scatter([1, 2, 3], [4, 5, 6], marker_z = [1, 2, 3])
scatter([1, 2, 3], [4, 5, 6], marker_z = [1, 2, 3, 4]) # allowed
scatter([1, 2, 3], [4, 5, 6], marker_z = [1, 2]) # error
@BeastyBlacksmith
Copy link
Member

I am mildly surprised that it doesn't cycle the short input

@t-bltg t-bltg added the bug label Nov 27, 2022
@BioTurboNick
Copy link
Member Author

I'm going to generalize this issue. All data entries should be treated the same. x, y, z, marker_z, fill_z, line_z, etc. should all just be considered components of the data series and have the same behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants