Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Require that derivatives preserve controls #87

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

goerz
Copy link
Member

@goerz goerz commented Aug 30, 2024

For non-linear amplitudes or generators, the derivative w.r.t a control should return an object whose controls are a subset of the controls in the original amplitude/generator. This must be an object identity, otherwise there will be hard-to-figure-out bugs. Previously, this requirement was not made explicit.

For non-linear amplitudes or generators, the derivative w.r.t a control
should return an object whose controls are a subset of the controls in
the original amplitude/generator. This must be an object identity,
otherwise there will be hard-to-figure-out bugs. Previously, this
requirement was not made explicit.
@goerz goerz added the bug Something isn't working label Aug 30, 2024
@goerz
Copy link
Member Author

goerz commented Aug 30, 2024

@stefan-o This should catch the issue we were discussing the other day

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.9%. Comparing base (fae356e) to head (e879915).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #87     +/-   ##
========================================
+ Coverage    85.7%   85.9%   +0.3%     
========================================
  Files          14      14             
  Lines         559     567      +8     
========================================
+ Hits          479     487      +8     
  Misses         80      80             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goerz goerz merged commit e879915 into master Aug 30, 2024
5 checks passed
@goerz goerz deleted the derivs-preserve-controls branch August 30, 2024 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant