You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And your Manifest.toml file has Foo at version 2.0.0.
Now suppose that Foo releases version 2.0.1.
Your existing compat entry of Foo = "2" includes this new release 2.0.1. So CompatHelper will not make an PR to bump your compat entry for Foo. After all, you don't need to bump your compat entry for Foo.
But, since you made the decision to check your Manifest.toml into source control, perhaps you would like to update your Manifest.toml file so that it has Foo at version 2.0.1 instead of version 2.0.0?
I think we should have the option for CompatHelper to make a PR in these cases, so that you can keep your Manifest.toml files up-to-date even if your compat entries do not need to be bumped.
As with everything in CompatHelper, there will be a keyword argument that allows you to enable or disable this feature.
The question is: what should the default value be? Should this feature be enabled by default or disabled by default?
Doing this by default (i.e., detect it automatically by checking if Manifest.toml files are checked in) would be great. I think it's consistent with Manifest.toml files updated by default.
Consider this situation. Your
Project.toml
file looks like this:And your
Manifest.toml
file hasFoo
at version2.0.0
.Now suppose that
Foo
releases version2.0.1
.Your existing compat entry of
Foo = "2"
includes this new release2.0.1
. So CompatHelper will not make an PR to bump your compat entry forFoo
. After all, you don't need to bump your compat entry forFoo
.But, since you made the decision to check your
Manifest.toml
into source control, perhaps you would like to update yourManifest.toml
file so that it hasFoo
at version2.0.1
instead of version2.0.0
?I think we should have the option for CompatHelper to make a PR in these cases, so that you can keep your
Manifest.toml
files up-to-date even if your compat entries do not need to be bumped.As with everything in CompatHelper, there will be a keyword argument that allows you to enable or disable this feature.
The question is: what should the default value be? Should this feature be enabled by default or disabled by default?
@christopher-dG @fredrikekre - Would love to get your input on this.
The text was updated successfully, but these errors were encountered: