Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Ignore a given package #404

Open
theogf opened this issue Feb 1, 2022 · 3 comments
Open

[FR] Ignore a given package #404

theogf opened this issue Feb 1, 2022 · 3 comments

Comments

@theogf
Copy link

theogf commented Feb 1, 2022

When CompatHelper is used for subdirs, e.g. docs or eventual examples, one wants to use the latest commit version of the current PR or of master/main from the parent repo/package.
Therefore putting a compat for the parent package does not makes sense. A solution would be to pass a list of packages to ignore when running CompatHelper.jl, maybe a blacklist keyword?

@DilumAluthge
Copy link
Member

As a short-term workaround, if you put a compat entry of the form e.g.

[compat]
Foo = ">= 1.2.3"

Then CompatHelper won't make any PRs to modify the compat entry for Foo.

@theogf
Copy link
Author

theogf commented Feb 1, 2022

My problem is that I would like to not put any compact so that the GH actions for creating the docs and other things use the dev version of the package.

@lucaferranti
Copy link

a blacklist keyword would indeed be nice.

The propoesd workaround does not set an uper-bound and hence would not work if I don't want to support a new breaking version of a dependency (for lack of bandwidth to upgrade or other reasons).

A few options off the top of my head:

  • use a blacklist keyword an support a compat-settings.yml file that can be put in the the repository to pass the list of blacklisted packages to CompatHelper.jl
  • do not open a PR if the version is specified in the form < 0.3
  • do not open the PR if there's a similar one (either open or closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants