Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experience from trying out the process #46

Closed
tpapp opened this issue Apr 3, 2019 · 5 comments
Closed

experience from trying out the process #46

tpapp opened this issue Apr 3, 2019 · 5 comments

Comments

@tpapp
Copy link
Contributor

tpapp commented Apr 3, 2019

Thanks for all the great work. I tried registering a package, here are some suggestions:

  1. README should clarify that the user should install the relevant app, currently RegistratorTest app

  2. It would be great if commands did not have to be quoted with `` (like bors), if that is necessary for some reason, please clarify in the README.

  3. It is unclear if (a) issue edits or (b) issue comments trigger the bot. Experimentally, comments seem to work.

  4. I suspect that tagging a new version should be triggered the same as registering, please clariy this. In general, please add some detailed suggestions about version/release management, as various ideas were discussed and it may not be clear which one ended up being implemented.

@nkottary
Copy link
Member

nkottary commented Apr 3, 2019

It was discussed earlier somewhere that tags/releases wouldn't be the best way to register because if there are problems, like in some cases project file is missing or incomplete then a new tag and release is required for triggering registration.

The other thing is that tags and releases are not really required for the Pkg system since all version info is contained in Versions.toml. So tags and releases can be decoupled from this process. Also note that the same tag/release can go to multiple registries so (i think) it shouldn't be tied to the registration process.

@nkottary
Copy link
Member

nkottary commented Apr 3, 2019

Registrator's README as well as https://juliaregistrator.github.io both mention "Click here to install" in the beginning. I thought you might have missed that.

@tpapp
Copy link
Contributor Author

tpapp commented Apr 3, 2019

Yes, I missed it, maybe a button like this could help?

https://img.shields.io/badge/-install%20app-blue.svg

@nkottary
Copy link
Member

nkottary commented Apr 3, 2019

Yup, good idea.

@nkottary
Copy link
Member

nkottary commented Apr 8, 2019

The new README.md should clarify this issue.

@nkottary nkottary closed this as completed Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants