Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure the Nouns, tags vs labels, are used properly #626

Closed
dehann opened this issue Aug 17, 2020 · 2 comments
Closed

make sure the Nouns, tags vs labels, are used properly #626

dehann opened this issue Aug 17, 2020 · 2 comments
Assignees
@Affie
Labels
API standardization
Milestone
v0.24.1

Comments

@dehann
Copy link
Member

dehann commented Aug 17, 2020 •
edited
Loading

e.g.

addVariable!(fg, label, varType, tags=[:POSE;])

see Noun definitions:
https://github.com/JuliaRobotics/DistributedFactorGraphs.jl/wiki/Standard-Definitions-of-API-via-verbs-and-set-theory#noun-object
@dehann dehann added this to the v0.0.x milestone Aug 17, 2020
@Affie
Copy link
Member

Affie commented Aug 18, 2020

At least partially address by #629

@dehann dehann changed the title make sure tags vs labels is used properly make sure tags vs labels are used properly Apr 25, 2021
@dehann dehann changed the title make sure tags vs labels are used properly make sure the Nouns, tags vs labels, are used properly Apr 25, 2021
@Affie Affie modified the milestones: v0.0.x, v0.24.1 Aug 28, 2024
@Affie
Copy link
Member

Affie commented Aug 28, 2024

I haven't seen the wrong usage in a while, I think we can close this and open specific issues if we find more.

@Affie Affie closed this as completed Aug 28, 2024
@Affie Affie self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Affie Affie

Labels
API standardization
Projects
None yet
Milestone
v0.24.1
Development

No branches or pull requests
2 participants
@dehann @Affie