-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function signature in documentation #207
Comments
I'm quite excited about https://juliadocs.github.io/DocStringExtensions.jl/stable/#DocStringExtensions.SIGNATURES |
Signatures of our Krylov solvers are not updated often, I updated the docstrings with #208. |
I think we should iterate with the DocstringsExtensions.jl authors to see if it's possible to get the result we want. It's a general principle that doesn't only apply to Krylov.jl. I'm not worried about the output parameters. We usually describe those in a section of the docstring and that's sufficient. |
@amontoison yes :) Thanks. |
The current documentation of user-facing functions, e.g.,
Krylov.cg
,Krylov.minres
, etc., does not include these functions' signature.It makes it hard for newbies like me to know how exactly to call a function, without going through the source code.
Here is an example of what I had in mind, for
Krylov.cg
:The conjugate gradient method to solve the symmetric linear system
Ax=b
.The method does not abort if A is not definite.
A preconditioner
M
may be provided in the form of a linear operator and isassumed to be symmetric and positive definite.
M
also indicates the weighted norm in which residuals are measured.Arguments
A
: Left-hand sideb::AbstractVector
: Right-hand sideKey-word arguments
M
: user-provided preconditioneratol
: absolute tolerancertol
: relative toleranceitmax::Int
: maximum number of iterations...
Even just the signature would be useful.
The text was updated successfully, but these errors were encountered: