Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use metaprogramming to generate all out-of-place methods #888

Closed
2 tasks done
amontoison opened this issue Oct 13, 2024 · 0 comments · Fixed by #894
Closed
2 tasks done

Use metaprogramming to generate all out-of-place methods #888

amontoison opened this issue Oct 13, 2024 · 0 comments · Fixed by #894
Assignees
@amontoison
Labels
enhancement

Comments

@amontoison
Copy link
Member

amontoison commented Oct 13, 2024 •
edited
Loading

A few methods have specific arguments and we don't generate the associated out-of-place methods in krylov_solve.jl.
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/main/src/krylov_solve.jl#L46-L47

  • window :: 5 -> lslq, lsmr, lsqr, minres, symmlq
  • memory :: 20 -> diom, dqgmres, fom, gmres, fgmres, gpmr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontoison amontoison

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate all out-of-place methods in krylov_solve.jl amontoison/Krylov.jl
1 participant
@amontoison