Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-solver parameters #63

Open
d-monnet opened this issue Mar 11, 2024 · 3 comments
Open

Sub-solver parameters #63

d-monnet opened this issue Mar 11, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@d-monnet
Copy link

Should sub-solver parameters also be included in parameters structures ?
If SolverParameters.jl is intended to provide an interface for fine-tuning optimization, I think they should.
One shortcoming is that the current solvers' interfaces in JSOSolvers.jl do not allows to pass parameters to the sub-solvers in SolverTools.jl.

@tmigot
Copy link
Member

tmigot commented Mar 11, 2024

I would say so. Do you mean we need a mechanism to build a SolverParameter structure for a solver that itself depend on a SolverParameter?
That's good idea, we should definitely think about it.

@tmigot tmigot added the enhancement New feature or request label Mar 11, 2024
@d-monnet
Copy link
Author

I'm not sure how to do that properly....
One thing that bothers me a bit is that, for example trunk, does not allow to set the acceptance and trust region update parameters.
If we modify the JSOSolvers' solvers interface to pass these kind of parameters to their sub-solvers, then we can put them directly in their SolverParameter structures (no need to have another SolverParameter structure for the subsolver).

@tmigot
Copy link
Member

tmigot commented Mar 11, 2024

I think it's good to have the parameters of the subsolver also in the parameters of the solver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants