-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHOLMOD doesnt call cholmod_l_finish
#205
Comments
We should if we can. But like you said, doesn't really matter. |
With the use of task local storage in #206, do we need to clean this up when a task finishes? |
Will added a finalizer so it get called now, hence why i closed it. SparseArrays.jl/src/solvers/cholmod.jl Line 155 in 0944c41
|
This is good to close yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In practice I doubt this is a major issue, but it seems odd to me. Is there a reason we don't call
cholmod_l_finish
on the Common objects before Julia quits? @ViralBShah you might know?The text was updated successfully, but these errors were encountered: