Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHOLMOD doesnt call cholmod_l_finish #205

Closed
rayegun opened this issue Aug 4, 2022 · 4 comments
Closed

CHOLMOD doesnt call cholmod_l_finish #205

rayegun opened this issue Aug 4, 2022 · 4 comments

Comments

@rayegun
Copy link
Member

rayegun commented Aug 4, 2022

In practice I doubt this is a major issue, but it seems odd to me. Is there a reason we don't call cholmod_l_finish on the Common objects before Julia quits? @ViralBShah you might know?

@ViralBShah
Copy link
Member

We should if we can. But like you said, doesn't really matter.

@SobhanMP SobhanMP closed this as completed Aug 7, 2022
@ViralBShah
Copy link
Member

ViralBShah commented Aug 7, 2022

With the use of task local storage in #206, do we need to clean this up when a task finishes?

@ViralBShah ViralBShah reopened this Aug 7, 2022
@SobhanMP
Copy link
Member

SobhanMP commented Aug 7, 2022

Will added a finalizer so it get called now, hence why i closed it.

common = finalizer(cholmod_l_finish, Ref(cholmod_common()))

@rayegun
Copy link
Member Author

rayegun commented Aug 7, 2022

This is good to close yes

@rayegun rayegun closed this as completed Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants