Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added specialized method for 3-argument dot with diagonal matrix #565

Merged
merged 9 commits into from
Oct 22, 2024
Merged

added specialized method for 3-argument dot with diagonal matrix #565

merged 9 commits into from
Oct 22, 2024
+70 −0

Conversation

matbesancon
Copy link
Contributor

Closes #563

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (313a04f) to head (031c5fd).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/linalg.jl 92.30% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   84.09%   84.13%   +0.04%     
==========================================
  Files          12       12              
  Lines        9102     9159      +57     
==========================================
+ Hits         7654     7706      +52     
- Misses       1448     1453       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dkarrasch
dkarrasch requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The comments refer to both methods actually. As for the length checks, perhaps you could add tests for all mismatching cases?

src/linalg.jl Outdated Show resolved Hide resolved
src/linalg.jl Outdated Show resolved Hide resolved
dkarrasch
dkarrasch reviewed Oct 15, 2024
View reviewed changes
src/linalg.jl Outdated Show resolved Hide resolved
@dkarrasch dkarrasch merged commit f10d4da into main Oct 22, 2024
10 checks passed
@dkarrasch dkarrasch deleted the diag-sparse-dot branch October 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

@rayegun rayegun Awaiting requested review from rayegun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slow 3-argument dot with sparse vectors
2 participants
@matbesancon @dkarrasch