We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am using ShortString.jl on a 32 bit system. On a 32 bit system mmhash128_a is mmhash128_4 which is used here: https://github.com/JuliaString/ShortStrings.jl/blob/fcacbe7e596f0a2544c3a62ab3500775dbcf139c/src/hash.jl#L3-L6
mmhash128_a
mmhash128_4
I get this error from hashing a ShortString:
hash
ShortString
LoadError: MethodError: no method matching unsafe_load(::UInt32) Closest candidates are: unsafe_load(!Matched::Ptr) at pointer.jl:105 unsafe_load(!Matched::Ptr, !Matched::Integer) at pointer.jl:105 Stacktrace: [1] mmhash128_4(::Int32, ::UInt32, ::UInt32) at depot/packages/MurmurHash3/rOsVB/src/MurmurHash3.jl:408 [2] hash at depot/packages/ShortStrings/j6S0g/src/ShortStrings.jl:16 [inlined]
The code that is hit is :. Note that we are passing in a UInt rather than a Ptr
UInt
Ptr
MurmurHash3.jl/src/MurmurHash3.jl
Lines 405 to 418 in a7beaab
I think the problem is that a method is missing. On a 64 bit system mmhash128_8_a is hit, and it has an overload that takes an Unsigned
mmhash128_8_a
Unsigned
Lines 123 to 124 in a7beaab
The text was updated successfully, but these errors were encountered:
OK! When I was adapting MurmurHash3 to make ShortString efficient, it looks like I missed that 32-bit case! I'll try to fix this weekend
Sorry, something went wrong.
bump
Fixed by PR #13
No branches or pull requests
I am using ShortString.jl on a 32 bit system.
On a 32 bit system
mmhash128_a
ismmhash128_4
which is used here:
https://github.com/JuliaString/ShortStrings.jl/blob/fcacbe7e596f0a2544c3a62ab3500775dbcf139c/src/hash.jl#L3-L6
I get this error from
hash
ing aShortString
:The code that is hit is :.
Note that we are passing in a
UInt
rather than aPtr
MurmurHash3.jl/src/MurmurHash3.jl
Lines 405 to 418 in a7beaab
I think the problem is that a method is missing.
On a 64 bit system
mmhash128_8_a
is hit, and it has an overload that takes anUnsigned
MurmurHash3.jl/src/MurmurHash3.jl
Lines 123 to 124 in a7beaab
The text was updated successfully, but these errors were encountered: