Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utf8proc_utf8class array is unused ... ? #98

Open
madscientist opened this issue Feb 17, 2017 · 3 comments
Open

utf8proc_utf8class array is unused ... ? #98

madscientist opened this issue Feb 17, 2017 · 3 comments

Comments

@madscientist
Copy link
Contributor

Maybe someone needs this somewhere, but it's not used anywhere in utf8proc; removing it still allows proper linking and all the tests still pass...

 UTF8PROC_DLLEXPORT extern const utf8proc_int8_t utf8proc_utf8class[256] ...
@stevengj
Copy link
Member

It used to be used in utf8proc_iterate, but that usage was removed in 6249e6b

I agree that it can be removed. It's not documented. Technically, since this is exported, I guess it requires a major version bump.

@nalimilan
Copy link
Member

Better wait for a real API change then, it would be too annoying to change SONAME just to remove an unused export.

@madscientist
Copy link
Contributor Author

I don't care about the export so much as the unused data table in utf8proc.c, but it's not huge so the additional extra size is not that big of a deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madscientist @nalimilan @stevengj