Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward taylor expansion keyword arguments to internal substitutions #1429

Merged

Conversation

hersle
Copy link
Contributor

@hersle hersle commented Feb 5, 2025

Fixes the added test.

taylor() calls substitute() internally, which uses fold=true by defaults, which evaluates numerical expressions, which may not always be desired. These changes allow passing fold=true to prevent it.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 8.88%. Comparing base (eced900) to head (9a5651c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/taylor.jl 0.00% 12 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1429   +/-   ##
======================================
  Coverage    8.88%   8.88%           
======================================
  Files          51      51           
  Lines        4876    4876           
======================================
  Hits          433     433           
  Misses       4443    4443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 95e4016 into JuliaSymbolics:master Feb 5, 2025
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants