Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-piracy check misses certain functions #155

Closed
jishnub opened this issue Jun 28, 2023 · 0 comments · Fixed by #156
Closed

Type-piracy check misses certain functions #155

jishnub opened this issue Jun 28, 2023 · 0 comments · Fixed by #156

Comments

@jishnub
Copy link
Contributor

jishnub commented Jun 28, 2023

The method at https://github.com/JuliaArrays/BlockArrays.jl/blob/6970e33327fd87243ec6bfc4526243f62ae53382/src/blocklinalg.jl#L133-L134

@propagate_inbounds Base.view(A::FillArrays.AbstractFill, I::Union{Real, AbstractArray, Block}...) =
    FillArrays._fill_getindex(A, Base.to_indices(A, I)...)

is committing type-piracy, but this was not flagged by Aqua. Importing Base.view, and changing the function name to view results in the piracy test correctly flagging this method. Perhaps relevant: FillArrays extends view after importing it, and not Base.view directly.

This method is available on BlockArrays v0.16.33.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant