-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run the @testset
if there are no tests
#319
Don't run the @testset
if there are no tests
#319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
==========================================
- Coverage 74.90% 74.77% -0.14%
==========================================
Files 11 11
Lines 761 761
==========================================
- Hits 570 569 -1
- Misses 191 192 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But ideally a maintainer of this package should review / merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed made little sense to print the empty testsets for testsets that were intentionally skipped. Thanks
@testset
if there are no tests
Some testing tools complain if a
@testset
is empty. So don't run empty test sets.