Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run the @testset if there are no tests #319

Merged
merged 5 commits into from
Jan 26, 2025

Conversation

kuszmaul
Copy link
Contributor

Some testing tools complain if a @testset is empty. So don't run empty test sets.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (1fca5d9) to head (fdba062).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Aqua.jl 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   74.90%   74.77%   -0.14%     
==========================================
  Files          11       11              
  Lines         761      761              
==========================================
- Hits          570      569       -1     
- Misses        191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@nickrobinson251 nickrobinson251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

But ideally a maintainer of this package should review / merge

src/Aqua.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed made little sense to print the empty testsets for testsets that were intentionally skipped. Thanks

Project.toml Outdated Show resolved Hide resolved
@lgoettgens lgoettgens changed the title Don't run the @testset if there are no tests Don't run the @testset if there are no tests Jan 26, 2025
@lgoettgens lgoettgens enabled auto-merge (squash) January 26, 2025 12:53
@lgoettgens lgoettgens merged commit 065acb6 into JuliaTesting:master Jan 26, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants