Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic code styling and formatting checks #14

Closed
JulianFP opened this issue Oct 4, 2024 · 2 comments
Closed

Add automatic code styling and formatting checks #14

JulianFP opened this issue Oct 4, 2024 · 2 comments
Labels
high priority will be among the next things we do NFR enhancement Improvement regarding a non-functional requirement (e.g. testing)

Comments

@JulianFP
Copy link
Owner

JulianFP commented Oct 4, 2024

Define a standard way of code style by setting up a formatter. This formatter should run in both the Github actions CI and using a pre-commit hook.
@JulianFP JulianFP added high priority will be among the next things we do planned for test run NFR enhancement Improvement regarding a non-functional requirement (e.g. testing) labels Oct 4, 2024
@dokempf
Copy link
Collaborator

dokempf commented Oct 4, 2024

If you use pre-commit anyway, https://pre-commit.ci/ is the way to go: It will run as a bot on your PRs. No need to duplicate logic in CI.

@dokempf dokempf mentioned this issue Oct 4, 2024
Closed
@JulianFP JulianFP mentioned this issue Oct 7, 2024
Merged
@JulianFP
Copy link
Owner Author

JulianFP commented Oct 9, 2024

Closed with #15

@JulianFP JulianFP closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority will be among the next things we do NFR enhancement Improvement regarding a non-functional requirement (e.g. testing)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dokempf @JulianFP