Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to route controller" opens with improper path casing #19

Closed
theRealPadster opened this issue Jan 25, 2023 · 2 comments
Closed

"Go to route controller" opens with improper path casing #19

theRealPadster opened this issue Jan 25, 2023 · 2 comments

Comments

@theRealPadster
Copy link

theRealPadster commented Jan 25, 2023

Notes:

  • I'm using macOS 13.1
  • When I cmd+click, it opens the controller file fine (since macOS is case-insensitive), but the folder and filename casings in the breadcrumbs and tab name are incorrect.
  • I'm not sure if this is a bug with the extension or VS Code itself.

Package version

Using AdonisJS Extension v0.9.1

Node.js and npm version

  • node: 16.14.0
  • npm: 8.3.1

Sample Code (to reproduce the issue)

  • Add /app/Controllers/Http/StripeController.ts
  • In /start/routes.ts:
Route.group(() => {
  Route.post('/add-customer', 'StripeController.addCustomer').as('add-customer');
  Route.post('/payment-intent', 'StripeController.generatePaymentIntent').as('add-payment-intent');
}).prefix('/stripe').as('stripe');
  • Then cmd + click on StripeController.generatePaymentIntent and it opens /app/controllers/Http/Stripecontroller.ts
  • The proper path is /app/Controllers/Http/StripeController.ts

image

image

@Julien-R44
Copy link
Owner

Hey, thanks for the detailed report

I also noticed that, and will need to investigate a bit more, but looks like a bug with VSCode itself :

microsoft/vscode#123660
microsoft/vscode#94307

@Julien-R44
Copy link
Owner

This should be fixed with 1.1.5 pre-release. Feel free to re-open if not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants