Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm workspaces detection should not find the same workspace twice #2

Closed
targos opened this issue Apr 30, 2022 · 0 comments
Closed

npm workspaces detection should not find the same workspace twice #2

targos opened this issue Apr 30, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@targos
Copy link

targos commented Apr 30, 2022

When npm workspaces are used, npm creates for each workspace a symbolic link under node_modules that points to the module in the workspace. The problem is that this extension finds it and then proposes two options when you try for example to list routes:
Screenshot 2022-04-30 at 13 25 51

If there are no use cases for looking inside node_modules, these folders can just be ignored. Otherwise, it may be possible to use fs.realpath to make sure the same absolute path isn't listed twice.

@Julien-R44 Julien-R44 self-assigned this Apr 30, 2022
@Julien-R44 Julien-R44 added the bug Something isn't working label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants