Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@trace not updating with method redefinition #14

Open
MasonProtter opened this issue Sep 6, 2018 · 2 comments
Open

@trace not updating with method redefinition #14

MasonProtter opened this issue Sep 6, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@MasonProtter
Copy link

MasonProtter commented Sep 6, 2018

If one defines a method, uses @trace on that method and then redefines the method and runs @trace on it again, it will give the output from the old method definition, not the new one. This seems to be a pretty major bug.

julia> using Traceur

julia> foo() = -10.0:10.0
foo (generic function with 1 method)

julia> foo()
-10.0:1.0:10.0

julia> @trace foo()
-10.0:1.0:10.0

julia> foo() = -10:10
foo (generic function with 1 method)

julia> foo()
-10:10

julia> @trace foo()
-10.0:1.0:10.0
@pfitzseb
Copy link
Member

pfitzseb commented Sep 7, 2018

I suspect that happens because of JuliaLabs/Cassette.jl#6, but it's definitely rather unfortunate.

@pfitzseb pfitzseb added the bug Something isn't working label Sep 7, 2018
@MikeInnes
Copy link
Member

If ASTInterpreter and Vinyl can be upgraded to 1.0, it'd be better to switch back to them to avoid this. Cassette makes sense right now just because it works, but we don't really need this to be compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants