Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Babel's preset-typescript once dependencies catch up with it #496

Closed
toolness opened this issue Mar 2, 2019 · 1 comment · Fixed by #721
Closed

Use Babel's preset-typescript once dependencies catch up with it #496

toolness opened this issue Mar 2, 2019 · 1 comment · Fixed by #721

Comments

@toolness
Copy link
Collaborator

toolness commented Mar 2, 2019

I closed #492 without merging mainly because of istanbuljs/istanbuljs#237. Once it gets fixed, I think it may be good to just migrate entirely to Babel's preset-typescript, remove ts-jest. and use babel-loader instead of ts-loader.
@toolness toolness mentioned this issue Mar 4, 2019
Merged
@toolness
Copy link
Collaborator Author

It looks like the fix has been merged into Babel master and will be part of 7.5.0, which should be out soon. It also looks like moving off ts-jest will speed up our tests, too.

@toolness toolness mentioned this issue Jul 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use latest version of Babel, drop ts-jest and ts-loader JustFixNYC/tenants2
1 participant
@toolness