Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e05e3db

Browse files
jacobbednarzJustin Holmes
authored and
Justin Holmes
committedSep 18, 2020
Add ID to CertificatePackAdvancedCertificate (cloudflare#522)
* Add `ID` to `CertificatePackAdvancedCertificate` This wasn't intentionally required however for cloudflare/terraform-provider-cloudflare#778 to work , this is now.
1 parent fe47819 commit e05e3db

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed
 

‎certificate_packs.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ type CertificatePackRequest struct {
5050
// CertificatePackAdvancedCertificate is the structure of the advanced
5151
// certificate pack certificate.
5252
type CertificatePackAdvancedCertificate struct {
53+
ID string `json:"id"`
5354
Type string `json:"type"`
5455
Hosts []string `json:"hosts"`
5556
ValidationMethod string `json:"validation_method"`

‎certificate_packs_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ func TestCreateAdvancedCertificatePack(t *testing.T) {
232232
mux.HandleFunc("/zones/023e105f4ecef8ad9ca31a8372d0c353/ssl/certificate_packs/order", handler)
233233

234234
certificate := CertificatePackAdvancedCertificate{
235+
ID: "3822ff90-ea29-44df-9e55-21300bb9419b",
235236
Type: "advanced",
236237
Hosts: []string{"example.com", "*.example.com", "www.example.com"},
237238
ValidityDays: 365,
@@ -278,6 +279,7 @@ func TestRestartAdvancedCertificateValidation(t *testing.T) {
278279
mux.HandleFunc("/zones/023e105f4ecef8ad9ca31a8372d0c353/ssl/certificate_packs/3822ff90-ea29-44df-9e55-21300bb9419b", handler)
279280

280281
certificate := CertificatePackAdvancedCertificate{
282+
ID: "3822ff90-ea29-44df-9e55-21300bb9419b",
281283
Type: "advanced",
282284
Hosts: []string{"example.com", "*.example.com", "www.example.com"},
283285
ValidityDays: 365,

0 commit comments

Comments
 (0)
Please sign in to comment.