-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for an optional link filtering function #119
Labels
Comments
zeke
changed the title
allow
add support for an optional link filtering function
Nov 19, 2019
linksToSkip
to be a function
I jumped the gun and opened a PR for this anyway: #120 |
This sounds great, and thanks for the PR! I left some feedback over there :) |
Thank you again for the PR! This was fixed in #120 - the release should be coming out momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @JustinBeckwith and maintainers. This is a nice module! Thanks for writing it.
In the current API doc:
This works, but it can be cumbersome to write exclusion rules just using regular expressions. It would be nifty if this option (or a new option) could be passed a function instead of an array. The function would take the given link URL as input and return a Boolean indicating whether to skip it or not:
I'd be willing to open a PR to add support for this. Would you be open to this change?
The text was updated successfully, but these errors were encountered: