-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add declaration true to compilerOptions to generate d.ts files #576
Merged
JustinBeckwith
merged 1 commit into
JustinBeckwith:main
from
khendrikse:fix/declaration-of-type-files
Oct 30, 2023
Merged
fix: add declaration true to compilerOptions to generate d.ts files #576
JustinBeckwith
merged 1 commit into
JustinBeckwith:main
from
khendrikse:fix/declaration-of-type-files
Oct 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Thank you for the fix!
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 16, 2024
This was referenced Jul 16, 2024
This was referenced Jul 16, 2024
This was referenced Sep 23, 2024
This was referenced Nov 1, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JustinBeckwith! I noticed that since
6.0.0
there were no.d.ts
files generated anymore into the build folder.I found out it was because of this line. Because of that config missing, we lost
"declaration": true
.If this was not intended, maybe it's worth adding it? Thanks!