Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add declaration true to compilerOptions to generate d.ts files #576

Merged

Conversation

khendrikse
Copy link
Contributor

@khendrikse khendrikse commented Oct 30, 2023

Hi @JustinBeckwith! I noticed that since 6.0.0 there were no .d.ts files generated anymore into the build folder.

I found out it was because of this line. Because of that config missing, we lost "declaration": true.

If this was not intended, maybe it's worth adding it? Thanks!

Copy link
Owner

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thank you for the fix!

@JustinBeckwith JustinBeckwith merged commit b806665 into JustinBeckwith:main Oct 30, 2023
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@khendrikse khendrikse deleted the fix/declaration-of-type-files branch October 30, 2023 18:36
This was referenced Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants