Regarding the false imputations from a developer of the PR: https://github.com/Jyers/Marlin/pull/1905

[mriscoc]

First, I recognize the great work of Jacob Myers with his UI and his contributions, I know that he doesn't have anything to do with the false imputations from one of his collaborators.

Some user has published a Pull Request that is clearly a copy of the functionalities of the Professional Firmware, I know that Imitation is the sincerest form of compliment and I agree with you try to implement those great features. I also agree with the use of some of the files I made available to the public, but I don't agree with the removal of the authorship.

He says that my code is a copy from others code, If I use a file from others, I never remove the authorship from the file, but sometimes I add a link to note from where that file was found.

He has never provided any proof of his false claims. On the contrary, I will proceed to support my claims.

From the file: diag_endstops.cpp almost all the code was copied from endstop_diag.cpp

His file:

Marlin/Marlin/src/lcd/e3v2/jyersui/diag_endstops.cpp

Lines 56 to 61 in 223899b

	void draw_ends_label(FSTR_P const flabel=nullptr) {
	JYERSUI::cursor.x = 40;
	if (flabel) JYERSUI::Draw_String(F(flabel));
	JYERSUI::Draw_String(F(": "));
	JYERSUI::MoveBy(0, 25);
	}

Professional Firmware file:
https://github.com/mriscoc/Ender3V2S1/blob/5562e7535c84155f3ec359b1b9f776ef1a0499ff/Marlin/src/lcd/e3v2/proui/endstop_diag.cpp#L45-L50

And others lines...

Also, many lines from the DWINUI Enhanced library were copied and renamed for example:

His file:

Marlin/Marlin/src/lcd/e3v2/jyersui/jyersui.cpp

Lines 83 to 134 in 223899b

	// Get screen x coordinates from text column
	uint16_t JYERSUI::ColToX(uint8_t col) {
	return col * fontWidth(font);
	}
	// Get screen y coordinates from text row
	uint16_t JYERSUI::RowToY(uint8_t row) {
	return row * fontHeight(font);
	}
	// Set text/number color
	void JYERSUI::SetColors(uint16_t fgcolor, uint16_t bgcolor, uint16_t alcolor) {
	textcolor = fgcolor;
	backcolor = bgcolor;
	buttoncolor = alcolor;
	}
	void JYERSUI::SetTextColor(uint16_t fgcolor) {
	textcolor = fgcolor;
	}
	void JYERSUI::SetBackgroundColor(uint16_t bgcolor) {
	backcolor = bgcolor;
	}
	// Moves cursor to point
	// x: abscissa of the display
	// y: ordinate of the display
	// point: xy coordinate
	void JYERSUI::MoveTo(int16_t x, int16_t y) {
	cursor.x = x;
	cursor.y = y;
	}
	void JYERSUI::MoveTo(xy_int_t point) {
	cursor = point;
	}
	// Moves cursor relative to the actual position
	// x: abscissa of the display
	// y: ordinate of the display
	// point: xy coordinate
	void JYERSUI::MoveBy(int16_t x, int16_t y) {
	cursor.x += x;
	cursor.y += y;
	}
	void JYERSUI::MoveBy(xy_int_t point) {
	cursor += point;
	}
	// Draw a Centered string using arbitrary x1 and x2 margins
	void JYERSUI::Draw_CenteredString(bool bShow, uint8_t size, uint16_t color, uint16_t bColor, uint16_t x1, uint16_t x2, uint16_t y, const char * const string) {
	const uint16_t x = _MAX(0U, x2 + x1 - strlen_P(string) * fontWidth(size)) / 2 - 1;
	DWIN_Draw_String(bShow, size, color, bColor, x, y, string);
	}

Professional Firmware file:
https://github.com/mriscoc/Ender3V2S1/blob/5562e7535c84155f3ec359b1b9f776ef1a0499ff/Marlin/src/lcd/e3v2/proui/dwinui.cpp#L107-L158

The same with screenlock.cpp which is a copy of lockscreen.cpp and so on...

He claims that these files are a copy of some Prusa file, again, post a proof with link and line numbers as I did. Maybe with that you can help me to do better documentation and restore some forgotten authorship.

[mriscoc]

His answer: #1909, again a bunch of falsehoods, but no real links with line numbers to compare.
Why copy from my files if the "original" sources are available according to him?